search

hot9cups / probdists

PyPi package for modelling Probability distributions
MIT License
7 stars 18 forks source link

Add Bernoulli Distribution with unittest and usage #28

Closed basil08 closed 3 years ago

basil08 commented 3 years ago

Added Bernoulli with its unittest and usage.

And few minor fixes.

basil08 commented 3 years ago

@hot9cups I have no idea what is wrong with from probdists import Bernoulli.

And, there are couple of trailing whitespaces, I'll fix them later.

hot9cups commented 3 years ago

The import is failing probably because you haven't changed __init__.py suitably.

Also, there's going to a change with the sample data files path and the way they're tested in the unittests, which should hopefully be merged into the repo by tomorrow. Therefore please wait till that's done(I'll ping you), then refresh your fork of the repo and create a fresh PR.

hot9cups commented 3 years ago

Therefore please wait till that's done(I'll ping you), then refresh your fork of the repo and create a fresh PR.

@basil08 Everything's been resolved now with the codebase, so you can go ahead and continue working :)

Also, be sure to refresh your fork to the latest version of the repo to avoid merge conflicts.

hot9cups commented 3 years ago

Are you working on this? I've added additional github actions and tests which doesn't work on PRs opened before the addition took place. Request you to make a new PR.