search

hotchemi / Android-Rate

Android-Rate is a library to help you promote your android app by prompting users to rate the app after using it for a few days.
http://hotchemi.github.io/Android-Rate
MIT License
724 stars 216 forks source link

setRemindInterval takes only time #104

Open phajduk opened 8 years ago

phajduk commented 8 years ago

Hi. I would like to implement method similar to setRemindInterval but it would take number of launches of the app instead of days. Name proposition is setRemindLaunchTimes. It would allow us to show the dialog again after for example next 5 launches. @hotchemi what do you think?

phajduk commented 8 years ago

I checked the code and it looks like if we go for it then this will be complicated much more. I'm also wondering what will happen when we setup for example:

.setInstallDays(10)
.setLaunchTimes(3)

Will it be shown after 3rd launch which has been made before 10th day? I think it's not. Is it intended?

Foivos-Stamopoulos commented 8 years ago

Exact same questions here. Thanks!

adamfisher commented 6 years ago

I've created a pull request for this feature as I am also looking for this. I'm not 100% certain I updated everything I needed and didn't see any tests but hoping this does the trick...

https://github.com/hotchemi/Android-Rate/pull/134