search

hotchemi / Android-Rate

Android-Rate is a library to help you promote your android app by prompting users to rate the app after using it for a few days.
http://hotchemi.github.io/Android-Rate
MIT License
724 stars 216 forks source link

Crash when PlayMarket is not installed #119

Open zyvpeople opened 7 years ago

zyvpeople commented 7 years ago

Application is crashed when press 'Rate' but PlayMarket is not installed. Maybe you should check for ResolveInfo when call 'startActivity' and notify client code with listener?

FlyingTopHat commented 7 years ago

Issue #53 is similar, and in that @hotchemi provides code for checking whether the Google Play service is available, and states:

Considering whether google play services is installed or not isn't library's responsibility, I think

Perhaps including the reasoning/code in the project's README might help?