search

hotchemi / Android-Rate

Android-Rate is a library to help you promote your android app by prompting users to rate the app after using it for a few days.
http://hotchemi.github.io/Android-Rate
MIT License
720 stars 216 forks source link

Cast "threshold" from Int type to long type #139

Open yuna-yano opened 6 years ago

yuna-yano commented 6 years ago

It corresponds to issue #138.

hotchemi commented 6 years ago

Thx and LGTM! Let me look into CI.

AlexanderLS commented 6 years ago

@yuna-yano your commits were merged into https://github.com/Vorlonsoft/AndroidRate/ (Releases 1.0.9+)

yuna-yano commented 6 years ago

@hotchemi In Travis CI, it seems that an error appears with the following command.

$ echo no | android create avd --force -n test -t android-21 --abi armeabi-v7a Error: Target id is not valid. Use 'android list targets' to get the target ids.

When searching, Issue like this came out.

https://github.com/travis-ci/travis-ci/issues/6606

I think this is a problem of the CI environment.

It is another repository, but for reference. https://github.com/gameclosure/devkit/issues/19

Thank you.