Add the ability to set a maximum number of dialog showings within a year’s time from the date of ‘installation’

[AlexanderLS]

@elhicks I want to merge your commits to https://github.com/Vorlonsoft/AndroidRate (Release 1.1.7+)... Could you please explain me about this ability? Why you need it? Why other library users need it? Thank you!

[elhicks]

Hey Alex,

The particular app I needed to add ratings capability to, part of the acceptance criteria is the product owner wanted to put a hard limit on how many times we show the dialog within a year's time. Apparently this semi-mirrors an aspect of iOS ratings requests. Thought the change might be useful for other people who get similar requests so I tossed out a pull requests from the fork I made for the small change.

Thanks,

Ed

[AlexanderLS]

Hi @elhicks

Thank you for your idea. I found corresponding iOS documentation - System Rating and Review Prompts

Your Pull request has 3 significant errors:

• It doesn't limit the display of the dialog whin 365-day period (last 365 days from any date). It limits from 0 day after install to 364 day after install, from 365 day after install to 768 day after install, from 769 day after install to 1092 day after install, etc.
• You use DateUtils.YEAR_IN_MILLIS, but this constant is actually the length of 364 days, not of a year, not of 365 days!
• You use APP_INSTALL_DATE, not DIALOG_FIRST_LAUNCH_TIME_DATE.

I implemented this feature by myself and included it in the AndroidRate Library Release 1.1.7+.

AppRate.with(this).set365DayPeriodMaxNumberDialogLaunchTimes(short);

Best regards, Alexander Savin