search

hotchemi / Android-Rate

Android-Rate is a library to help you promote your android app by prompting users to rate the app after using it for a few days.
http://hotchemi.github.io/Android-Rate
MIT License
724 stars 216 forks source link

Arabic Language Added #142

Open RadhoueneRouached opened 6 years ago

AlexanderLS commented 6 years ago

Hi @RadhoueneRouached

AndroidRate Library has Arabic translation already:

    <string name="rate_dialog_title">قيم هذا التطبيق</string>
    <string name="rate_dialog_message">إذا كنت تسمتع باللعب بهذا التطبيق، فما رأيك في تقييمه؟ لن يأخذ منك أكثر من دقيقة. شكرًا لك على دعمك!</string>
    <string name="rate_dialog_ok">قيّمه الآن</string>
    <string name="rate_dialog_cancel">ذكّرنا لاحقًا</string>
    <string name="rate_dialog_no">لا، شكرًا</string>

We want to merge your commit. What can you say about your translation? Which is best - our or yours? As I know our is best for Egyptian people.

RadhoueneRouached commented 6 years ago

My translation is the best for not only all native arabic speaker but also anyone who speaks arabic. Your translation is a word-for-word translation.

AlexanderLS commented 6 years ago

@RadhoueneRouached Our translation translated by "Tomedes - Smart Human Translations" and cost me $0,07 per word. Is it so bad or there can be something useful?

Also you can use our version of this library - https://github.com/Vorlonsoft/AndroidRate (compatible and more than 213 commits ahead, 17,760 ++ lines, 5,532 -- lines)