search

hotchemi / Android-Rate

Android-Rate is a library to help you promote your android app by prompting users to rate the app after using it for a few days.
http://hotchemi.github.io/Android-Rate
MIT License
724 stars 216 forks source link

Added support for custom String content #78

Closed urgas9 closed 8 years ago

urgas9 commented 8 years ago

I have added support for custom String content (title, message, button texts) at runtime. I designed it in such way that the API is backward compatible. If you are setting content with a String object it has priority over resources id. So, if String attribute is not null, String attribute is used...

This could be implemented also another way, minimizing number of methods and providing cleaner code. DialogOptions constructor should receive Context object, which would enable us to use only methods that return String objects (without resource identifiers), method for setting message text would look something like this: public String getMessageText() { if(meesageText != null) return messageText; else return mContext.getString(R.string.rate_dialog_message); }

hotchemi commented 8 years ago

Thx I'm gonna review it.

urgas9 commented 8 years ago

Please review the latest commit.