Added the ability to force kill the process on closing the tunnel

hotforfeature / wct-browserstack

WCT plugin that enables support for testing via Browserstack

1 stars 2 forks source link

Added the ability to force kill the process on closing the tunnel #10

Closed Motonstron closed 6 years ago

Motonstron commented 6 years ago

We currently have an issue on our Jenkins containers where the process just hangs on completion of the tests. I've added the ability to set a forceKillOnComplete flag either on the command line or in the wct.conf allowing people to specify if they want to force the process to be terminated.

I have testes locally on Mac OS and on out containers with success.

It looks like wdio-browserstack have implemented the same from someone as a short term fix. Not sure why this started happening.

Motonstron commented 6 years ago

@hotforfeature are you still maintaining this repo, If not would it be possible to take ownership?

hotforfeature commented 6 years ago

Hey @garfty! Sorry, I must have missed the email with this PR. Looks good to me!

Motonstron commented 6 years ago

All good, thanks for the merge.