search

hotg-ai / rune

Rune provides containers to encapsulate and deploy edgeML pipelines and applications
Apache License 2.0
134 stars 15 forks source link

Throttling not working in microspeech_agg proc block #64

Closed Mi1ind closed 3 years ago

Mi1ind commented 3 years ago

Output in proc_block/microspeech_agg/lib.rs

thread 'tests::throttling' panicked at 'attempt to add with overflow'

Output with actual data:

<MISSING>

Michael-F-Bryan commented 3 years ago

@Mi1ind can you provide steps for reproducing this issue or paste a backtrace?

Mi1ind commented 3 years ago

@Mi1ind can you provide steps for reproducing this issue or paste a backtrace?

The first was the output from running cargo test throttling from proc_block/lib.rs

The second was from testing data which kartik used. He shared a screenshot of it in chat.

The branch is feature/microspeech

Mi1ind commented 3 years ago

Haven't been able to debug this today but I have a suspicion that saturating_sub might be behaving weirdly.

Michael-F-Bryan commented 3 years ago

The XXX_agg proc blocks have been removed so this issue is no longer relevant. See https://github.com/hotg-ai/rune/issues/116#issuecomment-842174192 for more.