search

hotio / qbittorrent

https://hotio.dev/containers/qbittorrent
GNU General Public License v3.0
116 stars 14 forks source link

Use WebUI port from ENV variable for qbittorrent process #3

Closed nstetter closed 3 years ago

nstetter commented 3 years ago

Use the ENV variable WEBUI_PORTS for the qbittorrent main process to be able to set the WebUI port manually

nstetter commented 3 years ago

@mrhotio why did you close the PR?

mrhotio commented 3 years ago

Because it'll break stuff

nstetter commented 3 years ago

Do you have a better approach in mind for changing the WebUI port? 8080 is so commonly used, it conflicts with other services.

mrhotio commented 3 years ago

Under what circumstances does it conflict for you?

nstetter commented 3 years ago

It's not that I have an actual conflict at hand, but I strongly dislike using default ports for containerized applications, just to avoid the possibility of conflicts.

Could you explain why using the webui-port flag will break stuff? linuxserver.io is using it too.

mrhotio commented 3 years ago

lsio doesn't have builtin vpn support...you can always map to any other port, in most cases the internal post is irrelevant, except when routing other containers over this container's network....for which sabnzbd would cause an issue, but there's a workaround in my sab container for that....ignoring the fact that it would be pointless running sab over a vpn connection....

nstetter commented 3 years ago

In this case port mapping does not work correctly. If I try to map the port like -p 1234:8080 I only get a blank page saying 'unauthorized' on <IP>:1234.

mrhotio commented 3 years ago

Works fine for me...maybe try playing with the qbit settings.

nstetter commented 3 years ago

When comming through a reverse proxy it works for me too. Only when directly accessing it from the same network without TLS it does not work. As I use it over the proxy anyway it is usable for me.

mrhotio commented 3 years ago

Said nothing about any reverse proxy....I run permanently with -p 8088:8080...So the piece of info you linked is imo wrong.

mrhotio commented 3 years ago

Seems I jumped the gun here and thought you wrote WEBUI_PORT, did not see the S and it turns out that on Unraid it is indeed required to make use of this...that's why I was never able to reproduce the issues some people had, because on Ubuntu it works without flaw.

Long story short, thanks for the elegant solution.