search

hotjar / hotjar-js

Bring Hotjar directly to your application
https://hotjar.github.io/hotjar-js/
MIT License
49 stars 8 forks source link

feat: Add support for Events API #10

Closed bobbyg603 closed 2 years ago

bobbyg603 commented 3 years ago

Fixes #9

bobbyg603 commented 3 years ago

hi @hereismass, is this repo accepting contributions? do you need anything else from me to get this merged? please let me know.

hereismass commented 3 years ago

Hey, sorry for the delay, did not see the PR :) the changes looks good.

cc @arrwhidev for approval as I am not working on this area anymore

bobbyg603 commented 3 years ago

@hereismass thank you!

arrwhidev commented 3 years ago

Hey @bobbyg603 👋

Thanks for the PR, it looks good.

Can you please update the README and the demo before I approve?

Thank you.

bobbyg603 commented 3 years ago

Hey @bobbyg603 👋

Thanks for the PR, it looks good.

Can you please update the README and the demo before I approve?

Thank you.

Sure thing, I'll amend the commit in the near future. Thanks for the review!

bobbyg603 commented 3 years ago

Hey @bobbyg603 👋

Thanks for the PR, it looks good.

Can you please update the README and the demo before I approve?

Thank you.

Hi @arrwhidev, I've amended the commit. I think logging an event for an error is a really powerful use case (we use this a lot at BugSplat), however, I'll admit it's a bit awkward to click the button and see a danger alert in the demo. Please let me know if you'd like me to show a different example. Thanks!

bobbyg603 commented 2 years ago

Hi @arrwhidev would love to get this merged so we could use the official hotjar package and deprecate our custom version. Please let me know if you need anything from me in order to get this merged. Thanks!