search

hotkit / django-async

A simple asynchronous execution Django application with proper database transaction management
http://www.kirit.com/Django%20Async
Boost Software License 1.0
35 stars 20 forks source link

Add field cancelled to async_job table #10

Closed DjNero closed 10 years ago

DjNero commented 10 years ago

Include south migration step to migrate async_job table

KayEss commented 10 years ago

You need to update your merge by pulling in upstream changes first so it will merge cleanly otherwise it's too hard to review.

KayEss commented 10 years ago

The bit that's missing now is that it doesn't appear to integrate with Siraset's feature for deleting old jobs. It now needs to consider cancelled jobs as well as executed ones otherwise the cancelled ones will build up.

The group semantics and progress are going to be need to be updated in suitable ways as well. It's not 100% clear to me off the top of my head what that ought to be. There is a corner case where a group has some cancelled jobs and some un-executed ones. I don't know if that should be valid or not (at least, I can't think of a use case where we'd want that situation).

KayEss commented 10 years ago

BTW, you also need to update ChangeLog and setup.py.

KayEss commented 10 years ago

Can you pull from my develop and resolve the merge conflicts?