search

hotmeteor / receiver

Receiver is a drop-in webhook handling library for Laravel.
MIT License
384 stars 21 forks source link

[Fix] GitHub signature header #19

Closed amiranagram closed 1 year ago

amiranagram commented 1 year ago

This PR fixes the GitHub Webhooks signature header. Additionally, value of the signature starts at char index 7 since the value looks like sha256=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

ninjaparade commented 1 year ago

@hotmeteor LGTM, 👍

hotmeteor commented 1 year ago

pls fix tests

ninjaparade commented 1 year ago

@amiranagram wtf dude. Tests are failing. image

amiranagram commented 1 year ago

Fixed @hotmeteor :saluting_face:

hotmeteor commented 1 year ago

@amiranagram Athankya