search

hotmeteor / spectator

OpenAPI testing for PHP
MIT License
285 stars 52 forks source link

Allow comma separated values in the query parameters #135

Closed CWDN closed 1 year ago

CWDN commented 1 year ago

Wasn't able to assert for valid comma separated values in query parameters e.g. ?include=foo,bar as the value passed to the JSON schema package was still a string and not exploded.

When looking online about how people define comma separated values in query params this StackOverflow seems to be the agreed way (https://stackoverflow.com/a/66829618).

This PR just adds a little piece of logic to explode the value by comma if the property explode is false in the parameter.

designvoid commented 1 year ago

Please please could this be merged?

designvoid commented 1 year ago

@hotmeteor any reason this can't be merged?

evan-burrell commented 1 year ago

@CWDN - Would you be able to rebase this to have this branch be Laravel 10 compatible?

designvoid commented 1 year ago

Any chance of this getting merged with this new round of merges @hotmeteor ?

designvoid commented 1 year ago

YAY!!! Thanks so much!!! 👍