search

hotosm / HDM-CartoCSS

CartoCSS project focused on the Humanitarian Data Model
Other
138 stars 41 forks source link

Bridge casings interrupted by lower level roads #156

Closed pnorman closed 8 years ago

pnorman commented 11 years ago

18/41580/89793

The bridge casing on the primary is interrupted by the tertiary road below, making it look like they connect.

yohanboniface commented 11 years ago

Interesting. I was just thinking about this kind of issue some day ago, I think I can add a third ordering, to draw smaller roads before bigger (when in the same layer of course). It could if this also.

pnorman commented 11 years ago

This shouldn't depend on road classification, even if the bottom road was primary it still shouldn't look like they connect since one is layer=0 and the other is layer=2.

yohanboniface commented 11 years ago

This shouldn't depend on road classification, even if the bottom road was primary it still shouldn't look like they connect

You're right.

Certainly linked to the way I handle casing, i.e. with a separate attachment, drown before roads ways.

pnorman commented 11 years ago

Example of two motorways 17/20725/44914

This isn't really specific to the bridge tag in a way, the casings of higher z-order roads should probably always be drawn on top of lower z-order roads, regardless of bridge/tunnel tags.

pnorman commented 11 years ago

See also gravitystorm/openstreetmap-carto#188

yohanboniface commented 11 years ago

A 'z-index' may really really help for this kind of situations.

I think that the fix is to draw casing and road from a same layer together, and then draw the layer above, etc. So, without z-index, I will need to rejoin casing and roads in the same selector, which is not trivial at this point.

yohanboniface commented 8 years ago

Should be fixed with latest deploy, can you confirm?

pnorman commented 8 years ago

89793

44914