search

hotosm / HDM-CartoCSS

CartoCSS project focused on the Humanitarian Data Model
Other
139 stars 41 forks source link

Add Styling for POIs as areas #211

Open skorasaurus opened 10 years ago

skorasaurus commented 10 years ago

I'm a bit surprised this hasn't been mentioned here yet on the github tracker so perhaps it had been discussed in the past.

We do render the name tag for various polygons that are POI but do not add any styling for them. See: https://github.com/hotosm/HDM-CartoCSS/blob/7107a7e070871f86d874c7ebb3a7d8102934aa38/hdm.mml#L955

At the least, it would be helpful to add an outline of the polygon of the POI.

skorasaurus commented 10 years ago

there's already an issue specifically for public buildings

yohanboniface commented 10 years ago

I've added a quick darken for POI buildings, but I'm not sure we have to go too far on that way: I can see that putting a little bit of relief in POIs building in a generic way makes sense, but I don't see any way to make a more typed rendering semantically understable (i.e. a specific colour for say shops=shoes and another for shop=bakery, just to make an extreme example).

jaakkoh commented 10 years ago

Yea, from the top of my head I wouldn't want to see (m)any "POI tag" add color or pattern to a polygon object. .. Icon, yes. Color / possibly pattern for (some) landuses & similar "area descriptions" such as wood/forest, water - some building values perhaps. But not too much of these in a relatively generic style that the HDDM style intends to be.