search

hotosm / HDM-CartoCSS

CartoCSS project focused on the Humanitarian Data Model
Other
138 stars 41 forks source link

Render tower:type=communication (always) #217

Closed jaakkoh closed 10 years ago

jaakkoh commented 10 years ago

I just reported this issue (the other way around) to the openstreetmap-carto https://github.com/gravitystorm/openstreetmap-carto/issues/339. In Humanitarian style the issue is:

If there's a man_made=tower -- at least in conjunction with tower:type=communication -- then that is rendered in the Humanitarian style with an icon (example: http://osm.org/node/2489765793#map=17/12.07757/-86.24800&layers=HN ).

I think this same rendering should happen when using man_made=mast (at least with tower:type=communication), which currently doesn't ( http://osm.org/node/2666366790#map=20/12.08458/-86.24263&layers=HN ).

Perhaps all masts should be rendered with the icon, so it might make sense to add that too (perhaps as an additional option)?

yohanboniface commented 10 years ago

Not sure we need an icon for a mast, but maybe only a small circle, like for "power=pole"?

jaakkoh commented 10 years ago

My understanding is that there are actually masts that are quite tall, prominent and in some cases major landmarks. Tower (to my understanding) is a free-standing structure whereas masts are (at least usually) supported (by wires). Perhap's (ideally) there should be some additional data to define the prominence in rendering buy until we have that I think we'd do just fine using the same (current) tower icon for masts, too. .. Comparing the HDM tower (http://www.openstreetmap.org/node/2489765793#map=20/12.07926/-86.25211&layers=H) to Mapnik mast (http://www.openstreetmap.org/node/2666366790#map=19/12.08462/-86.24272&layers=N) or OpenCycleMap mast (http://www.openstreetmap.org/node/2666366790#map=18/12.08462/-86.24272&layers=CN) doesn't set them far apart from each other. Or just cross-use Mapnik or OCM mast?

jaakkoh commented 10 years ago

<3