search

hotosm / HDM-CartoCSS

CartoCSS project focused on the Humanitarian Data Model
Other
138 stars 41 forks source link

large areas in Germany are rendering as water #226

Closed skorasaurus closed 10 years ago

skorasaurus commented 10 years ago

issue originally filed at: https://github.com/hotosm/hotosm/issues/50

It is not fixed when I viewed the tiles minutes ago... If I have time in coming days, I'll try to replicate this on a local extract of Germany and find the culprit.

yohanboniface commented 10 years ago

I prefer to keep the rendering as is, and add the lake for real in Germany, it's a very nice place to go with my boat!

ToeBee commented 10 years ago

It appears to have something to do with the "Bergishes Land" multipolygon relation:
http://www.openstreetmap.org/relation/1240038

At a blind guess, I would say a member way may have had a natural=water or some other water related area tag added to it which then caused osm2pgsql to apply this tag to the entire relation. I saw something similar happen when someone accidentally added a building=yes way to a city boundary relation. The whole city suddenly got rendered as a building. I don't see a member way with such a tag right now though. I see a stream and a river as relation members but those are linear features so I don't think they would produce this.

yohanboniface commented 10 years ago

Thanks for the input! We were at the http://www.openstreetmap.org/relation/1240038#map=9/51.0189/7.6396 too thanks to @cquest, and it seems it has waterway=stream in the DB, as you are suggesting.

brb :)

yohanboniface commented 10 years ago

Let's remove stream from the WHERE clause for now, I don't really a stream being an area in any cases.

yohanboniface commented 10 years ago

Should be fixed over the night, the server is doing its best. Thanks @skorasaurus for the ping, @ToeBee and @cquest for the investigation, and @cquest again for the fix data side. I've also pushed a fix carto side, which will be live at next push.

harry-wood commented 10 years ago

Got another flood in Moscow: http://www.openstreetmap.org/#map=7/55.693/36.222&layers=H

yohanboniface commented 10 years ago

Gasp, global warming again? I've not pushed to production the new code last time, as we fixed the bug also on the data side and the server was already red :( Now it's pushed and restarted, I'm force-refreshing low level tiles.