search

hotosm / HDM-CartoCSS

CartoCSS project focused on the Humanitarian Data Model
Other
136 stars 41 forks source link

Support more scripts with Noto fonts #284

Closed mapmeld closed 6 years ago

mapmeld commented 7 years ago

I've seen an improvement to how Southeast Asian script labels are rendered on OpenStreetMap.org using the upgraded Mapnik (and possibly this recently merged PR to their carto style: https://github.com/gravitystorm/openstreetmap-carto/pull/2349 )

Would it be possible for the HOT style to use Noto fonts, too?

yohanboniface commented 7 years ago

Sounds good! I'll have a deeper look :)

yohanboniface commented 7 years ago

Just has a quick look: Noto only has four styles (regular, italic, bold, bold italic). The issue is that we are using semi-bold a lot, so this needs a bit of design decision whether to move down to regular or up to bold for each usage. I'll try to have a new look.

sommerluk commented 6 years ago

The next version of Noto is in development and will have support for various weights and widths: https://github.com/googlei18n/noto-fonts/blob/master/FAQ.md#what-are-googles-plans-for-noto-so-called-phase-3 There is an alpha version available yet: https://github.com/googlei18n/noto-fonts-alpha Not sure when the final Noto Phase III will be released…

yohanboniface commented 6 years ago

Thanks for the info! I'll digg into this, would love to support Noto, which as broader alphabets support.

sommerluk commented 6 years ago

Let me know if you have further questions (regarding the code for Noto in openstreetmap-carto)…

sommerluk commented 6 years ago

With https://github.com/googlei18n/noto-fonts/pull/967 now new Noto version with various weights is released at https://github.com/googlei18n/noto-fonts (dictionaries “hinted” and “unhinted”).

jidanni commented 6 years ago

Are you sure #293 is related? Does it have to do with Noto fonts? Isn't just showing empty boxes worse than showing the character, but just in a different font?

jidanni commented 6 years ago

As you see, every single Chinese character is gone http://www.openstreetmap.org/#map=19/24.15071/120.66228&layers=H

And as this area's official language is Chinese, wouldn't that impede any rescue operations etc. making this a critical bug?

jidanni commented 6 years ago

On the Korean example at the top of this bug page, there is plenty of Korean still visible. On my Chinese example every single last character is gone.

mapmeld commented 6 years ago

If it helps to identify the bug - Chinese characters are still visible on zoom-11 and broken on zoom-12

yohanboniface commented 6 years ago

OK, sorry, seems really a new bug, reopening #293