hotosm / HDM-CartoCSS

CartoCSS project focused on the Humanitarian Data Model
Other
138 stars 41 forks source link

Little rectangles on map, apparently names #293

Closed jidanni closed 6 years ago

jidanni commented 6 years ago

Please see https://github.com/openstreetmap/openstreetmap-website/issues/1669

yohanboniface commented 6 years ago

Thanks for the report. Tracked by #284

yohanboniface commented 6 years ago

cc @cquest

cquest commented 6 years ago

Looks like missing font problem or unhandled scripts by current font set...

Is this new (caused by last week upgrades) or was there before the upgrades ?

yohanboniface commented 6 years ago

Given the impact, I think (hope) it's new: http://www.openstreetmap.org/#map=18/24.15087/120.66270&layers=H

Funny thing, as stated by @mapmeld is the fonts are OK until zoom 11 (pregenerated levels).

sommerluk commented 6 years ago

Funny thing, as stated by @mapmeld is the fonts are OK until zoom 11 (pregenerated levels).

So my raw guess is also that this is a missing-font-problem on the server. If there have been changes on the server last week, that seems possible…

Note that “Unifont” has different names across different Linux distributions and distribution versions, so it’s worth the pain have both, "Unifont Medium" and "unifont Medium" in the list. (See https://github.com/gravitystorm/openstreetmap-carto/pull/429/files for details.)

yohanboniface commented 6 years ago

So my raw guess is also that this is a missing-font-problem on the server.

Why would the tiles be OK until zoom 11 then?

sommerluk commented 6 years ago

Okay, I thought “pre-rendered” ment that they are not rendered on the server…

Lukas Sommer

2017-11-06 8:10 GMT+00:00 Yohan Boniface notifications@github.com:

So my raw guess is also that this is a missing-font-problem on the server.

Why would the tiles be OK until zoom 11 then?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hotosm/HDM-CartoCSS/issues/293#issuecomment-342074458, or mute the thread https://github.com/notifications/unsubscribe-auth/AGg6hPZKDl_ftGW6v76ACCjMC8209BDHks5szr8PgaJpZM4QSc1q .

yohanboniface commented 6 years ago

Okay, I thought “pre-rendered” ment that they are not rendered on the server…

Ah, nope :) They are rendered through render_list script, as opposed to "on demand" for higher zoom levels (AFAIK, because I'm not running the server).

But checking the conf, it seems even the zoom 12 is supposed to be rendered, so my guess that the difference was coming from the difference generation process seems wrong.

@cquest could it be that something worked when you ran the render_list, and some later upgrade/conf change broke it? I'm on IRC if you are not on the metro ;)

cquest commented 6 years ago

Good catch from @sommerluk it is simply a change in the font name... unifont (12.04) > Unifont (16.04)

I've changed the xml directly, and it is now ok. A few tiles need to be re-rendered...

skorasaurus commented 6 years ago

Sounds like this can be closed now since the issue had been fixed in the code (https://github.com/hotosm/HDM-CartoCSS/commit/fd20003091d82e84c686451cda32576c1c5481bb) but had not yet been deployed, correct?

Re-open if I am misunderstanding and thank you for the report. :)

jidanni commented 6 years ago

I am now seeing the problem at levels 12 and 13. http://www.openstreetmap.org/#map=12/24.1636/120.6840&layers=H http://www.openstreetmap.org/#map=13/24.1636/120.6840&layers=H

cquest commented 6 years ago

Still re-rendering tiles...

jidanni commented 6 years ago

Problem still on level 12. I can't tell if you confirm the problem is all fixed on your end as the bug is already closed.

cquest commented 6 years ago

Zoom 12 is still rendering...