hotosm / MapCampaigner

Campaign management tool
BSD 3-Clause "New" or "Revised" License
38 stars 23 forks source link

Delete campaign #762

Closed Eleonore9 closed 4 years ago

Eleonore9 commented 5 years ago

Closes issue #669

delete-step1 delete-step2 delete-step3

russbiggs commented 4 years ago

Looks like there is some styling issues on this:

Screen Shot 2019-11-12 at 8 36 09 PM
Eleonore9 commented 4 years ago

@russbiggs this looks more like you can't see half of it! I've added screenshot in the PR description. I'm not sure of what's going on? How are you running it locally?

russbiggs commented 4 years ago

This looks pretty much complete. We just need to hide the delete button in the jinja template in the header in the case where the user is not a manager of the campaign. Although not necessarily secure it would be good to do a check on the delete handler server side as well.

Eleonore9 commented 4 years ago

This looks pretty much complete. We just need to hide the delete button in the jinja template in the header in the case where the user is not a manager of the campaign. Although not necessarily secure it would be good to do a check on the delete handler server side as well.

Sure! I hadn't realised it was to be done on my end.