Project overview - Githubissues

hotosm / MapCampaigner

Campaign management tool

BSD 3-Clause "New" or "Revised" License

38 stars 23 forks source link

Project overview #774

Closed Eleonore9 closed 4 years ago

Eleonore9 commented 4 years ago

status:

New UI for project overview and map
New UI for table header only
Get all features data from Overpass XML via a JSON file on S3
Data retrieved on the frontend, parsed and displayed using DataTables
Get data from modified campaign.json (for summary stats at the top)
Re-style dataTable

russbiggs commented 4 years ago

When campaign_contributors is an empty list it's showing []

This should be a number

russbiggs commented 4 years ago

theres a lot of code that doesnt seem to be used particularly in the lambda_functions/render/feature/ directory.

unnecessary print statements in lambda_functions/render/feature/aws.py
list method isn't used anywhere in lambda_functions/render/feature/aws.py
unused changes in lambda_functions/render/feature/utilities.py e.g create_feature_details_json

Eleonore9 commented 4 years ago

When campaign_contributors is an empty list it's showing []

This should be a number

When you had me look for the key "campaign_contributors" instead of "contributors" in campaign.json I thought you meant that the key for the total number of contributors would be renamed "campaign_contributors" in a separate PR. My bad!

Eleonore9 commented 4 years ago

OK, modifications done!

Eleonore9 commented 4 years ago

I've also rebased with develop so that should solve the merge conflict