hotosm / fAIr

AI Assisted Mapping
GNU Affero General Public License v3.0
74 stars 59 forks source link

Only accepted features should be included in the download data #223

Closed omranlm closed 6 days ago

omranlm commented 6 months ago

Describe the bug In the mapping page, only accepted features should be included in the download .. or clearly declare that the download would include all predicated features

To Reproduce Steps to reproduce the behavior:

  1. Go to mapping page, for example https://fair-dev.hotosm.org/start-mapping/120
  2. Click on run prediction
  3. Scroll down see the download as geojson button under options section
  4. Download the data and visualize it in QGIS and it will include all features

Expected behavior We should have the selected features only downloaded Another option is to clearly say it is downloading all data

Screenshots image

omranlm commented 6 months ago

CC @kshitijrajsharma

natrimmer commented 2 months ago

I'd like to ask clarifying questions with an example.

Here is a predication with some accepted features:

Screenshot 2024-07-10 at 14 54 20

And here is the downloaded GeoJSON from that prediction represented in QGIS:

Screenshot 2024-07-10 at 14 56 32

@omranlm is suggesting that if there are accepted features within the prediction that the GeoJSON downloaded when rendered should look like this:

Screenshot 2024-07-10 at 15 03 37

Is that a correct understanding of the problem? As for the exact feature, maybe it could end up being two buttons. One for all predicted features represented in the GeoJSON, and once the first feature is accepted an additional button displays for downloaded just the accepted feaetures in GeoJSON format.

kshitijrajsharma commented 2 months ago

I'd like to ask clarifying questions with an example.

Here is a predication with some accepted features:

Screenshot 2024-07-10 at 14 54 20

And here is the downloaded GeoJSON from that prediction represented in QGIS:

Screenshot 2024-07-10 at 14 56 32

@omranlm is suggesting that if there are accepted features within the prediction that the GeoJSON downloaded when rendered should look like this:

Screenshot 2024-07-10 at 15 03 37

Is that a correct understanding of the problem? As for the exact feature, maybe it could end up being two buttons. One for all predicted features represented in the GeoJSON, and once the first feature is accepted an additional button displays for downloaded just the accepted feaetures in GeoJSON format.

That's correct understanding!

omranlm commented 2 months ago

The 2 buttons idea sounds like a better solution.

We also got community feedback while piloting with HOT hubs to define an area of interest and run prediction for the whole area then share predictions as geojson, so that could be a 3rd button that takes are of interest and returns geojson (it might need queuing as response time would depend on the size of the area of interest)

natrimmer commented 1 month ago

So three different GeoJSON export options:

  1. Defined areas of interests within the dataset
  2. After running a prediction, all predicted features
  3. After accepting a feature, all accepted features