Project task index as an user facing task_id

[Sujanadh]

What type of PR is this? (check all applicable)

• [X] 🍕 Feature
• [ ] 🐛 Bug Fix
• [ ] 📝 Documentation
• [X] 🧑‍💻 Refactor
• [ ] ✅ Test
• [ ] 🤖 Build or CI
• [ ] ❓ Other (please specify)

Related Issue

• feature #1326
• feature #1418

Describe this PR

• uses project task index to use it as a task id starting from 0 for each individual project
• uses uuid as a XFormId(odk_form_id)
• saves odk_form_id in the database table xforms along with category and project_id there is still an issue uploading entities in the odk central need some changes in osm fieldwork for proper log, i.e. xform name is taken from xformid, now it has been changed to uuid ,now need clear distinction between xform name and xformid

  Screenshots

N/A

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

• 📖 Read the FMTM Contributing Guide: https://github.com/hotosm/fmtm/blob/main/CONTRIBUTING.md
• 📖 Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
• 👷‍♀️ Create small PRs. In most cases, this will be possible.
• ✅ Provide tests for your changes.
• 📝 Use descriptive commit messages.
• 📗 Update any related documentation and include any relevant screenshots.

[optional] What gif best describes this PR or how it makes you feel?

[spwoodcock]

Apologies Sujan, I have also been working on XForm related code and have created conflicts for you!

Code look good - we should discuss how best to integrate this into the frontend, as it may require updating a significant number of API endpoints for the frontend to pass the project_id+task_numer combo (instead of the task_id) 👍

[Sujanadh]

Only the user-facing id will be that project-specific id like that in QR pop up. But for the endpoints, we can still use the same id that we are using till now. Using both project_id and task_index won't be that good. And except id, we don't have other unique fields.

[Sujanadh]

So, we can limit the use of both project_id and task index only in submissions endpoints to interact with odk central.

[spwoodcock]

You are definitely right - the project_id and task_index combo isn't a good solution!

Looks like the task details from the API return both the id and index, so the best solution is probably to have both in place:

We use the task.id for referencing via the API, and use the index for user facing things. Nice update to the data extract task_id by the way 😄 I will update the frontend to show the index, then merge this PR.

[spwoodcock]

From a brief look I need to update:

• Submission page:

  

• Project detail page:

  

[spwoodcock]

All done - could you review this works ok @Sujanadh please? 🙏

[Sujanadh]

fixed the entity not being uploaded problem

[Sujanadh]

All done - could you review this works ok @Sujanadh please? 🙏

looks good so far

[Sujanadh]

One thing I noticed quickly was the order of task completion. they are not in ascending order.

[spwoodcock]

Nice work - thanks! 🎉