Better handle PMTile offline map paths - Githubissues

hotosm / fmtm

Field Mapping Tasking Manager - coordinated field mapping.

https://fmtm.hotosm.org/

GNU Affero General Public License v3.0

47 stars 46 forks source link

Better handle PMTile offline map paths #1552

Open spwoodcock opened 5 months ago

spwoodcock commented 5 months ago

Describe the bug

Currently state?.project?.projectOpfsBasemapPath is only set when the user clicks the lightning bolt to download/cache PMTiles in the browser.
When the project is changed (going to project details), the value of projectOpfsBasemapPath is not updated. It uses the previous value.
I added logic to not load the basemap if the projectId does not match the project id in the OPFS file path, but this is a hacky workaround.

To Reproduce

Download a PMTiles basemap.
Set a console.log on the projectOpfsBasemapPath param in ProjectDetailsV2.
Click the bolt to cache in browser.
Change to a different project.
See the console log of the path from the previous project.

Expected behavior

Remove the existing logic, including the projectOpfsBasemapPath param.
Instead, when the project details page loads, search the OPFS storage for a directory matching the project ID.
If there is a pmtiles archive under the project id directory, then we should grab and display it.
If there is no record in the OPFS for the project, we should not display any basemap.

spwoodcock commented 4 months ago

Moved to the mapper app milestone. No point fixing this on the current project details page, as it will be moved to the mapper app.