search

hotosm / fmtm

Field Mapping Tasking Manager - coordinated field mapping.
https://fmtm.hotosm.org/
GNU Affero General Public License v3.0
42 stars 45 forks source link

error message during submission download doesn't provide sense if there is no submission on that project #1582

Closed manjitapandey closed 1 month ago

manjitapandey commented 2 months ago

Is your feature request related to a problem? Please describe. Failed to download submission geojson message doesn't provide sense if there is no submission on that project

Describe the solution you'd like If there is no submissions on that project, the error message saying "Failed to download submission geojson " message provide confusion to users. We have to come up with different error message to avoid the confusion. like "there is no submission in this project". Open to other better options

Describe alternatives you've considered ![Uploading image.png…]()

spwoodcock commented 2 months ago

I think the screenshot didn't quite upload before submitting - could to reupload for clarity 🙏

spwoodcock commented 1 month ago

image

Agree this could be clearer.

If the API returns no submissions, we should have a different error message: No submission yet for project.

NSUWAL123 commented 1 month ago

@spwoodcock, I have made a PR to display dynamic message generated from the backend. So, I think the backend should generate an appropriate message. i.e. should generate an error if it's related to no submission or other thing as it's impossible on the frontend side.