hotosm / galaxy-api

Backend to fetch data from Underpass
https://galaxy-api.hotosm.org/latest/redoc
GNU Affero General Public License v3.0
14 stars 5 forks source link

Improve Data Quality : Username Endpoint #229

Closed kshitijrajsharma closed 2 years ago

kshitijrajsharma commented 2 years ago

Testing API Params : {"fromTimestamp":"2022-04-25T18:15:00.994Z","toTimestamp":"2022-04-30T18:14:59.994Z","osmUsernames":["Riyadi IRM-ED"],"issueTypes":["all"],"hashtags":["Indonesia"],"outputType":"geojson"}

Should return data quality issues with hashtags missingmaps within that time range inside that username

**This sample is taken by making sure we have data for that user on underpass so it should return result

d-rita commented 2 years ago

@itskshitiz321 does including the hashtag make it an intersection of results? I tested with: { "fromTimestamp": "2021-07-01T00:30:00.000", "toTimestamp": "2021-07-30T00:15:00.000", "osmUsernames": [ "Fadlilaa IRM-ED","Bert Araali" ], "issueTypes": [ "all" ], "outputType": "geojson", "hashtags":[] }. Without a hashtag input, I get results. When I add a hashtag, e.g missing maps, there is none. (it's entirely possible they did not use this hashtag but that is why I wanted to know if we combine the search to get only the intersecting results, and if there are none, it shows zero like in this case). If so, would we consider showing the available results even if they don't fit the hashtag? cc: @ramyaragupathy

kshitijrajsharma commented 2 years ago

@d-rita Yeah hashtags will work as intersection just like how mapathon will work