search

hotosm / galaxy-api

Backend to fetch data from Underpass
https://galaxy-api.hotosm.org/latest/redoc
GNU Affero General Public License v3.0
14 stars 5 forks source link

Big refactor: remove Insights data source and raw data support #356

Closed emi420 closed 1 year ago

emi420 commented 1 year ago

Big refactor

Removed Inisights as a data source

This PR includes the remove of all references to Insights, leaving Underpass as the only data source for statistics. The main reason for this is that Insights will be turned off soon.

Removed Raw data features

This feature was moved to a new exciting project: Export Tool. All functionality related to Raw Data was removed in this PR.

kshitijrajsharma commented 1 year ago

Thanks Emi ! Huge PR ! I will suggest having tests on endpoints level like this. So that we will know if anything is breakable by PR from end user perspective ! , I will go through the PR

emi420 commented 1 year ago

Action Items :

  • [x] Hashtag Stats Endpoints Doesn't work , PR is still referring to insight's hashtag table [IMP]

Done here:

https://github.com/hotosm/galaxy-api/pull/356/commits/672e618cd0cc8a1dba6234fcd2633105720bd88d

CC @kshitijrajsharma

kshitijrajsharma commented 1 year ago

I have approved the PR , for few case scenario i am getting null responses such as. 

{ "hashtag": "msf", "frequency": "w", "outputType": "json", "startDate": "2020-10-22", "endDate": "2020-12-22" }

Which is okay and negligible , Rest looks Good ! Great work !

emi420 commented 1 year ago

I have approved the PR , for few case scenario i am getting null responses such as.

{ "hashtag": "msf", "frequency": "w", "outputType": "json", "startDate": "2020-10-22", "endDate": "2020-12-22" }

Which is okay and negligible , Rest looks Good ! Great work !

The query looks good, it's just that data is missing in the DB for those dates, I'll start a process soon to fill what's is missing.