search

hotosm / hotosm-website

The website of the Humanitarian OpenStreetMap Team. See instructions below for writing blog posts or updating your profile.
https://www.hotosm.org
65 stars 99 forks source link

Update: program page #851

Closed Claurt07 closed 4 months ago

Claurt07 commented 4 months ago

Changes:

Screenshots of the change:

image
Claurt07 commented 4 months ago

@kshitijrajsharma @dakotabenjamin Thanks as always! some fixes to the program page requested by leadership.

Claurt07 commented 4 months ago

The Typos, I already took note and will correct them on Siteleaf, there has to be a last review by comms on the text on content so its not final. thank you dk :)

kshitijrajsharma commented 4 months ago

You are using tailwind css carrousel. Neat implementation ⭐️

Do mention this in PR and the reason behind for you to import the lib itself . Importing lib is okay , I just want to make sure whoever comes to this PR after will know why you made this decision instead of cdn.

One more small comment on css : I noticed your media css on base css, While testing you can have multiple views like phone, tablet and web . Based on which you can make sure carrousel doesn't get carried away when screen size changes . I think a lot of people will use cellphone browsing hot website . + It will be wise to make this carrousel content dynamic so that you will have option to change or implement new carrousel easily later on as request comes in .