search

hotosm / learnosm

LearnOSM.org content, Jekyll layouts & issue tracking. This repository is dedicated to helping people learn how to map in OpenStreetMap (OSM) and use many of the software and tools in the OSM community.
http://learnosm.org
MIT License
247 stars 189 forks source link

Improve search data file #315

Closed pyrog closed 7 years ago

pyrog commented 9 years ago
  1. The files generated by jekyll contain a lot of spaces and empty lines, especially all-translation.json used by the jQuery search script. It could be minified with a Jekyll plugin or ruby script run by travis/rake.
  2. Also, this file contain titles in all languages but the search script use only the current language. So, we could generate a file by language and load only one at a time.
  3. Search take care of accentuated char:
    • In french the search editeur return "Edition avancée", "Editer le Wiki OSM"
    • The search éditeur find "Éditer à distance…", "Éditeur iD", "Éditer avec JOSM"

:bulb: To "fix" this, I suggest to test a plugin with full text search capabilities like jekyll-lunr-js-search

althio commented 9 years ago

Originates from https://github.com/hotosm/learnosm/issues/19#issuecomment-13016637 Discussed in https://github.com/hotosm/learnosm/issues/150

Need to assess the proposal from @pyrog with

:bulb: To "fix" this, I suggest to test a plugin with full text search capabilities like jekyll-lunr-js-search

pyrog commented 9 years ago

See #328 to discuss how to use Travis.CI

Nick-Tallguy commented 7 years ago

Closing as stale. A champion willing to work on this is weL come to open it and work on it.