hotosm / learnosm

LearnOSM.org content, Jekyll layouts & issue tracking. This repository is dedicated to helping people learn how to map in OpenStreetMap (OSM) and use many of the software and tools in the OSM community.
http://learnosm.org
MIT License
247 stars 189 forks source link

fixed anchor for non-latin scripts #530

Closed Andygol closed 7 years ago

Andygol commented 7 years ago

Here is amendment for specifying anchors for non-latin scripts LTR and RTL writing

http://127.0.0.1:4000/fa/josm/start-josm/#یادگیری-ترسیم‌های-اولیه-در-josm 👇 persian image

and http://127.0.0.1:4000/uk/josm/start-josm/#точки-лінії-та-фігури-полігони 👇 ukrainian image

/cc @Nick-Tallguy

Nick-Tallguy commented 7 years ago

Thanks Andrew,

Sorry to have caused you the extra work.

I hope to be on my laptop later tonight and I'll do the pull then.

Regards

Nick (OSM=Tallguy) my phone is responsible for any spelling mistakes!

On 21 Jun 2017 15:17, "Andrey Golovin" notifications@github.com wrote:

Here is amendment for specifying anchors for non-latin scripts LTR and RTL writing

http://127.0.0.1:4000/fa/josm/start-josm/#یادگیری-ترسیم‌های-اولیه-در-josm 👇 [image: image] https://user-images.githubusercontent.com/369696/27388686-e1a167a4-56a4-11e7-9aaf-e1b98cfc1d57.png

and http://127.0.0.1:4000/uk/josm/start-josm/#точки-лінії-та- фігури-полігони 👇 [image: image] https://user-images.githubusercontent.com/369696/27388850-5bda6d86-56a5-11e7-8ec4-51a18fa66afd.png

/cc @Nick-Tallguy https://github.com/nick-tallguy

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hotosm/learnosm/pull/530#issuecomment-310092685, or mute the thread https://github.com/notifications/unsubscribe-auth/AGc1vSnKoy3RWo_a2t6DJ6aFK-GQOfs3ks5sGSX1gaJpZM4OBBCR .

Nick-Tallguy commented 7 years ago

Thanks @Andygol and @althio - merge done and all working well now, including the right to left pages. I'm just adding the ru and uk modules that were in the initial pull request.

Nick-Tallguy commented 7 years ago

I've checked all the uk modules that were included, and they were already in learnosm. The same with the other ru modules.

I think that is everything now, thanks.

althio commented 7 years ago

Cool I like it! Thanks @Andygol and @Nick-Tallguy 😄