search

hotosm / learnosm

LearnOSM.org content, Jekyll layouts & issue tracking. This repository is dedicated to helping people learn how to map in OpenStreetMap (OSM) and use many of the software and tools in the OSM community.
http://learnosm.org
MIT License
247 stars 189 forks source link

Added Vespucci Editor for mobile mapping #578

Closed mmlmendoza closed 5 years ago

mmlmendoza commented 5 years ago

I've noticed there's no guide for using Vespucci in the learnosm site. Made one since Vespucci is a good app for mobile mapping in Android and it's what I also use.

Nick-Tallguy commented 5 years ago

Hi mamon,

I'm travelling with limited internet access but hoping to look at your hard work in the next few days.

Nick my phone is responsible for any spelling mistakes!

On Mon, 8 Jul 2019, 08:53 mamon, notifications@github.com wrote:

I've noticed there's no guide for using Vespucci in the learnosm site. Made one since Vespucci is a good app for mobile mapping in Android and it's what I also use.

You can view, comment on, or merge this pull request online at:

https://github.com/hotosm/learnosm/pull/578 Commit Summary

  • merge
  • run
  • Delete run.bat
  • added existing file
  • add existing file
  • Merge pull request #3 from hotosm/gh-pages

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hotosm/learnosm/pull/578?email_source=notifications&email_token=ABTTLPMKMPQEEBDS7HCMGWTP6LW6XA5CNFSM4H6Y3RSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5Y7LOA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTTLPMPJKMDAA5MI2V74SLP6LW6XANCNFSM4H6Y3RSA .

Nick-Tallguy commented 5 years ago

Hi, I've had a quick look through, and it's looking good, but can I get you to make a few changes please. Our target audience is often in parts of the world with poor internet access, and we therefore have an image restriction of 800 pixels on the longest edge for any images. A quick look shows many of your images are far larger than this, and will slow or stop the site considerably if internet access is poor. Please reduce the images to 800px along longest edge.

_posts/en/0900-07-20-vespucci_en.md
Please make the following amendments;
line 49, add a space after the )
line 103, I think the last sentence should read "A new node will be added in the selected location."
line 124, I think this should read "Select what you want to redo."

Thanks for working on this.

Regards

Nick

mmlmendoza commented 5 years ago

Hi, I've had a quick look through, and it's looking good, but can I get you to make a few changes please. Our target audience is often in parts of the world with poor internet access, and we therefore have an image restriction of 800 pixels on the longest edge for any images. A quick look shows many of your images are far larger than this, and will slow or stop the site considerably if internet access is poor. Please reduce the images to 800px along longest edge.

_posts/en/0900-07-20-vespucci_en.md Please make the following amendments; line 49, add a space after the ) line 103, I think the last sentence should read "A new node will be added in the selected location." line 124, I think this should read "Select what you want to redo."

Thanks for working on this.

Regards

Nick

Hi! I've already edited my work based on your comments. I've already updated the _posts/en/0900-07-20-vespucci_en.md and reduced the dimensions of all the images.

This is my first contribution on GitHub so thank you for checking!

Nick-Tallguy commented 5 years ago

Hi @mmlmendoza I've pulled your work into the site, but at the moment the images are not displaying. I think you have named the images *.PNG, but in the .md file you have referenced them as .png - I can't work on this at the moment, but may have internet access later today or tomorrow. If you are able to correct this, that would be good, if not I'll work on it when I can.

Regards

Nick

mmlmendoza commented 5 years ago

Hi!

Thank you for notifying me. I've already edited the .md file and issued a new pull request.

On Thu, Jul 18, 2019 at 5:04 PM Nick Allen (OSM = Tallguy) < notifications@github.com> wrote:

Hi @mmlmendoza https://github.com/mmlmendoza I've pulled your work into the site, but at the moment the images are not displaying. I think you have named the images *.PNG, but in the .md file you have referenced them as .png - I can't work on this at the moment, but may have internet access later today or tomorrow. If you are able to correct this, that would be good, if not I'll work on it when I can.

Regards

Nick

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hotosm/learnosm/pull/578?email_source=notifications&email_token=AMHYQWM2MW7GIEY3T6NBZJLQAAW3NA5CNFSM4H6Y3RSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2H2RFA#issuecomment-512731284, or mute the thread https://github.com/notifications/unsubscribe-auth/AMHYQWIEGVUITQB5GYNTD5DQAAW3NANCNFSM4H6Y3RSA .