search

hotosm / learnosm

LearnOSM.org content, Jekyll layouts & issue tracking. This repository is dedicated to helping people learn how to map in OpenStreetMap (OSM) and use many of the software and tools in the OSM community.
http://learnosm.org
MIT License
247 stars 189 forks source link

Improvements for RTL #621

Closed iriman closed 4 years ago

iriman commented 4 years ago

issue #618

michael63-osm commented 4 years ago

@iriman Thank you for your work here. It might take a little bit before we can merge this as we have a staging site (see details on https://learnosm.org/en/contribute/translator/) where we have two more rtl languages, Arabic and Hebrew, which have to be considered apart from Farsi. Additionally, we do not edit foreign language versions of our documents here but automatically pull the translations from Transifex. Any additional modifications would have to be performed by scripting during the pull process.

Getting all this under one hood needs a few preparations and checks. But I hope to get this done within this week.

iriman commented 4 years ago

Very good, please let me know if there was any problem regarding rtl.

iriman commented 4 years ago

I dig into this a bit more. We can avoid changing anything on transifex side, instead use liquid to put a condition for the rtl languages to detect rtl.

I also renamed direction-dependent css rules to be more meaningful in both rtl and ltr.

Totally I guess this is a much cleaner way.

In case if not decided yet, I would like to suggest this approach.

I sent a PR to the staging site for review. https://github.com/Nick-Tallguy/Nick-Tallguy.github.io/pull/97

Thanks

michael63-osm commented 4 years ago

As you noticed I pulled your request on the staging site. Seems to work fine. And issuing pull requests on the staging site is our preferred way as we can try things out there without disrupting the main site. I will pull these changes over to the main site this weekend. Thanks again for your work.