search

hotosm / osm-analytics

OSM Analytics lets you interactively analyze how specific OpenStreetMap features are mapped in a specific region.
https://www.osm-analytics.org
BSD 3-Clause "New" or "Revised" License
103 stars 31 forks source link

Add Place= as one of the main metrics tool #97

Closed jjiglesiasg closed 4 years ago

jjiglesiasg commented 4 years ago

As Roads, Buildings, Rivers; Place tag should be a Very good Metric to know.

Thanks

cgiovando commented 4 years ago

Hi @jjiglesiasg - can you please send a PR against this configuration file with the proposed addition? https://github.com/hotosm/osm-analytics-config/blob/master/analytics.json

I believe the OSMA Cruncher reads that files directly and new layers would be added automatically to the website. Maybe the only place where new data would not be available, is the Comparison View tool - correct @tyrasd ?

tyrasd commented 4 years ago

@cgiovando you are right, the config file is fetched automatically, and with the next data update any new layers are on the map. Only the historic data for the "compare time periods" feature would not be available without manual intervention.

jjiglesiasg commented 4 years ago

I am Not really sure of how to place a Pull Request, but would be very nice if Tag:place could be added to the main metrics, like highways, buildings, amenities and hospitals

Thanks if you can help about

Hi @jjiglesiasg - can you please send a PR against this configuration file with the proposed addition? https://github.com/hotosm/osm-analytics-config/blob/master/analytics.json

I believe the OSMA Cruncher reads that files directly and new layers would be added automatically to the website. Maybe the only place where new data would not be available, is the Comparison View tool - correct @tyrasd ?

cgiovando commented 4 years ago

Hi @jjiglesiasg - I added places in this PR https://github.com/hotosm/osm-analytics-config/pull/2

@tyrasd please merge if it looks OK :)

jjiglesiasg commented 4 years ago

Thanks and Best Regards

From: Cristiano Giovando [mailto:notifications@github.com] Sent: Thursday, April 30, 2020 1:42 PM To: hotosm/osm-analytics osm-analytics@noreply.github.com Cc: Juan Jose Iglesias jjiglesiasg@gmail.com; Mention mention@noreply.github.com Subject: Re: [hotosm/osm-analytics] Add Place= as one of the main metrics tool (#97)

Hi @jjiglesiasg https://github.com/jjiglesiasg - I added places in this PR hotosm/osm-analytics-config#2 https://github.com/hotosm/osm-analytics-config/pull/2

@tyrasd https://github.com/tyrasd please merge if it looks OK :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hotosm/osm-analytics/issues/97#issuecomment-622001250 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOKQKQEABJESCZH6U4XESDRPGZ4ZANCNFSM4MNVJ3PA . https://github.com/notifications/beacon/AFOKQKVBML5EHGMFWKA3YQTRPGZ4ZA5CNFSM4MNVJ3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEUJPYYQ.gif

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient

Virus-free. http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient www.avg.com

tyrasd commented 4 years ago

It is merged now and should appear with the next data update in about 1 1/2 day.

tyrasd commented 4 years ago

in the meantime the new places layer is online (after a small scaling adjustment in https://github.com/hotosm/osm-analytics-config/commit/53bb76285136aa43de98d91c7a08308b33357734 and https://github.com/hotosm/osm-analytics-config/commit/7609ed8dc72dbf5371940b91cd7a8f2d0d500966 to make the heatmap look a bit better).