search

hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.
http://tasks.hotosm.org
Other
425 stars 156 forks source link

Use https URLs for openstreetmap.org oauth and api endpoints #1002

Closed grischard closed 6 years ago

grischard commented 6 years ago

The oauth endpoint must change soon or logins will break. The rest is just good practice.

bgirardot commented 6 years ago

@grischard Hi thank you very much for the PR, just wondering why you closed it.

Cheers, blake

grischard commented 6 years ago

Hi @bgirardot. I realised the oauth url had actually already been changed in 2015, so I didn't want to bother anyone with non-urgent fixes. I'm happy resubmitting a separate PR that converts all http://openstreetmap.org links to htps if you'd like?

Cheers,

Guillaume

bgirardot commented 6 years ago

I guess I need to look a little further into it because we did just get a notice that the TM2 was using regular http, for oauth, but maybe that is for installations that are not up to date.

Either way, thank you very much for the PR, it is much appreciated. I amy end up re-opening it so we can merge it in.

grischard commented 6 years ago

Yes, that is indeed for installations that haven't been updated since 2015.

ethan-nelson commented 6 years ago

For older installations, you may need to update your httplib2 module if you're getting handshake errors.