Task manager message notifications in language of sender, not reciever.

hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.

http://tasks.hotosm.org

Other

425 stars 156 forks source link

Task manager message notifications in language of sender, not reciever. #321

Open AndrewBuck opened 9 years ago

AndrewBuck commented 9 years ago

I got a message on the TM of one of my tiles being invalidated from a german user and the invalidated message is in the German language of the sender, rather than my chosen language of english. (At least I think this is what is happening) Notice that the tiles of my own that I have invalidated (when I clicked the 'done' button accidentally for example) show up in english as you would expect, but the one I received from the other user uses what I assume is their language settings.

See attached screenshot below for details:

task manager language

pgiraud commented 9 years ago

Nice catch.

pgiraud commented 9 years ago

I thought it would be easy to fix this one but we unfortunately don't store the user preferred language in the database. Only in cookies for now.

ethan-nelson commented 9 years ago

Suggestion from #465 inspires the use of adding subject strings as the page is loaded? The subject of each message type (validated, invalidated, etc.) could possibly be given a respective identifier, and then we could loop over the messages in the user_messages function and put in the correct language string based on the identifier.