hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.
http://tasks.hotosm.org
Other
425 stars 156 forks source link

Add a #validation tag to validator changesets #676

Open dekstop opened 9 years ago

dekstop commented 9 years ago

When someone edits a tile during validation, TM2 could add a #validation changeset tag to the editor's session, in addition to the other existing project tags.

Changeset tags are starting to prove useful for monitoring and evaluation purposes. However currently there is no means of distinguishing between the initial map edits, and subsequent validation edits. If we could distinguish the two we could more easily determine the cost and impact of validation work.

ethan-nelson commented 9 years ago

We can append that onto the comment here, assuming there is a variable passed in the request that can distinguish between a validate state and an edit state.

dekstop commented 9 years ago

Looking at the data model I don't think there is an explicit session flag or task state for validation. Instead this checks that...

the task is locked by the current user:

  if user and task.cur_lock and task.cur_lock.user == user

the task is marked as done:

  done = task.cur_state and task.cur_state.state == TaskState.state_done