search

hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.
http://tasks.hotosm.org
Other
425 stars 156 forks source link

JOSM sending incorrect remote control imagery command? #845

Open swise5 opened 8 years ago

swise5 commented 8 years ago

e.g. http://tasks.hotosm.org/project/1983 Project set up correctly with seemingly correct imagery URL (http://a.tiles.mapbox.com/v4/digitalglobe.n6ngnadl/{z}/{x}/{y}.png?access_token=pk.eyJ1IjoiZGlnaXRhbGdsb2JlIiwiYSI6ImNpbncxNzE4OTE1dm51a2x5dzlkMXI0eHUifQ.TPHGd-IakYZGSP1ja3WTbQ), however as of 18:27 BST, 6 Sep, 2016 this generates the following remote control request:

http://127.0.0.1:8111/imagery?title=Tasking+Manager+-+%231983&type=htt&url=…sb2JlIiwiYSI6ImNpbncxNzE4OTE1dm51a2x5dzlkMXI0eHUifQ.TPHGd-IakYZGSP1ja3WTbQ

which causes JOSM 10786 to return the response

HTTP Error 400: Bad Request

unknown type: htt
swise5 commented 8 years ago

Ok - apparently needed tms[22]: in front of it...have asked admin to change on our specific task. Thanks!

ethan-nelson commented 8 years ago

I'm going to reopen this issue because this came up with someone else a few weeks ago but a ticket was never opened. There should probably be some client-side validation of the imagery url before saving.