search

hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.
http://tasks.hotosm.org
Other
425 stars 156 forks source link

Don't let users validate a square they worked on #909

Closed aawiseman closed 7 years ago

aawiseman commented 7 years ago

Or something like that -- I've seen in a few cases were new editors mapped and area then marked it as validated and left behind bad data.

Or (more complicated) only let more experienced or approved people validate their own squares.

pgiraud commented 7 years ago

This was addressed a while ago. https://github.com/hotosm/osm-tasking-manager2/pull/602 It looks like we're facing a regression somewhere.

pgiraud commented 7 years ago

This should be checked server-side as well. Sorry for my poor review on this pull request.

smit1678 commented 7 years ago

I saw this working correctly on Friday at our workshop. New user tried to validate their own square but could not. @aawiseman did you happen to see this recently or replicate this?

pgiraud commented 7 years ago

@aawiseman FYI administrators or project managers can validate the tasks they worked on. Simple contributors don't.

aawiseman commented 7 years ago

Oh, my bad, I last saw it on the TeachOSM tasking manager. I do remember seeing it here though, but maybe that was before the code change? http://tasks.hotosm.org/project/1080

bgirardot commented 7 years ago

I think this is fixed. I will test and reopen if needed..

Thank you @aawiseman !