search

hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.
http://tasks.hotosm.org
Other
425 stars 156 forks source link

add donate text and banner #916

Closed smit1678 closed 7 years ago

smit1678 commented 7 years ago

For the current microgrant campaign. This PR adds the full banner that was previously implemented in https://github.com/hotosm/osm-tasking-manager2/pull/710. I've tested this locally and works well.

@ethan-nelson @pgiraud Can I get a quick review from either of you?

cc @bgirardot

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.901% when pulling f77a452e192d5715e494274f5c8e572e9c2cd0c6 on smit1678:add-banner into 2c101609e2591d13f3bcca48688b25f7d1b57adc on hotosm:master.

ethan-nelson commented 7 years ago

I think this would be better added custom on the HOT TM instance as opposed to merging into the code base. In fact, we may want to remove the banner currently displayed by default (especially if we're wanting to move towards a more generic-branded installation out of box). But I don't know others' thoughts about it.

smit1678 commented 7 years ago

@ethan-nelson Agreed but I don't think we're managing that specific deployment code anywhere but here. Do we want to just start a branch that is specific to the HOT deployment?

smit1678 commented 7 years ago

Ok quick update here. Will close this in favor of a new PR to with a new branch.

I've implemented this directly on the server and have started a hot-production branch that will have the HOT specific extras. Current deployment is up to date with https://github.com/hotosm/osm-tasking-manager2/releases/tag/2.13.2. There have been few changes on the server that I'm sorting through and have dumped into a local hot-production branch. Once it's cleaned up a bit, then we can push to the remote here so we can manage the code in shared space on this account.