search

hotosm / osm-tasking-manager2

Designed and built for Humanitarian OpenStreetMap Team collaborative emergency/disaster mapping, the OSM Tasking Manager 2.0 divides an area into individual squares that can be rapidly mapped by thousands of volunteers.
http://tasks.hotosm.org
Other
425 stars 156 forks source link

Timer resets to 1439 minutes after initial 120 minutes #983

Closed briandaviddavidson closed 6 years ago

briandaviddavidson commented 7 years ago

If you start a cell, then let the timer run down to 0 minutes, the timer will reset to 1439 minutes and doesn't appear to unlock until you physically click the button.

It also seems that if you get out, and then get back into the same cell, the timer moves twice as fast.

See attached gif

timeissues

skalca commented 7 years ago

1439 looks very close to 1440 minutes which is 24 hours. I believe this behaviour has something to do as how locked_time is stored in the database. At first it works ok, but then this value is read from database. And there it gets corrupted. Because time_left gets calculated with help of current time in UTC+0.

But then again, I cannot reproduce this behaviour from master branch.

briandaviddavidson commented 7 years ago

Interesting. So the gif above was reproduced on the main tasking manager site on this project

Has this been fixed in master and not deployed to the live version yet?

skalca commented 7 years ago

Well, I cannot reproduce it on master, so I guess it works. And also I can see that times are taken in UTC in master so that looks fine.