search

hotosm / osma-health

HOT Analytics for Health
12 stars 3 forks source link

Logical consistency validator #9

Open geohacker opened 6 years ago

geohacker commented 6 years ago

I'm inclined to propose that we build a generic OSMLint validator that takes two different tags: a base tag and an overlap tag and check if any features in either set overlaps the other.

@kamicut @smit1678 - what do you think?

This involves defining the tileset, but I think QA tiles will have a lot of the features. And for the sake of getting off the ground, we'll limit to checking building=residential over a water feature.

kamicut commented 6 years ago

@geohacker does that mean polygon intersection or also way to polygon? I am not familiar with the current state of tools but defining the problem precisely could lead us to one algorithm vs another.

geohacker commented 6 years ago

@kamicut umm I can't remember how we represent closed ways in QA tiles but I'm assuming they already come as polygons from Minjur.

kamicut commented 6 years ago

@geohacker what I mean is can we do a general Polygon/Polygon intersection here like in https://github.com/osmlab/osmlint/blob/master/validators/crossingBuildings/map.js#L15 but without the extra "building" requirement? Or do you envision the OSMLint validator to also check for non-closed ways?

geohacker commented 6 years ago

@kamicut got it, yes totally. I think we'd be using that approach just with a different set of tags. And btw, here's the list of tags that minjur converts to polygons.

And specifically for water features that aren't polygons already, we can turn them into polygons in the validator.

geohacker commented 6 years ago

@smit1678 @awright - we've not been able to make much progress on this one, and will have to push this to the back burner until we ship what we have so far.

cc @olafveerman @kamicut @ascalamogna

awright commented 6 years ago

was the challenge a technical or timing one?

On Mon, Apr 9, 2018 at 3:56 AM Sajjad Anwar notifications@github.com wrote:

@smit1678 https://github.com/smit1678 @awright https://github.com/awright - we've not been able to make much progress on this one, and will have to push this to the back burner until we ship what we have so far.

cc @olafveerman https://github.com/olafveerman @kamicut https://github.com/kamicut @ascalamogna https://github.com/ascalamogna

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hotosm/osma-health/issues/9#issuecomment-379666895, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEySgueQlU6bIHurIq5okFJFIHBdzUoks5tmxRHgaJpZM4SqKie .