Integration of MapRules

[giblet22]

We'd like to start the conversation around integrating MapRules into the tasking manager.

Service: https://github.com/radiant-maxar/maprules UI: https://github.com/radiant-maxar/maprules-ui Some ongoing work: https://github.com/radiant-maxar/maprules/issues/51#issue-442428290

If there are going to be major changes to the TM over the coming months, it may be better to delay implementation/develop in parallel to these changes.

[pantierra]

Thanks @giblet22.

The main goal for the Tasking Manager, as far as I see, is to define MapRules on a project level and give this to the integrated iD (#1358). I haven't seen the MapRules-UI so far and my immediate question would be whether the definition of MapRules should happen from within the TM and whether the MapRules-UI can/should be used for this, or whether this needs to be reimplemented specifically for the TM (with probably less/other options)?

What other use cases do we want to tackle? How do you think the UI should be built in the TM?

[giblet22]

@xamanu The way we currently have MapRules configured in our TM2 is in the Edit project area. It's just a separate tab, that way it's only tied to that specific project.

[zlavergne]

I'm curious to what degree MapRules will be "enforced" for TM users.

@giblet22 if a project has MapRules, does the use have to have every object abide exactly to the rules or is there some leeway?

With the iD integration, will it block saving if the objects don't adhere to the rules or does it act more like warnings/suggestions?

This may be answered somewhere else so I apologize if you're repeating yourself 😃

[giblet22]

@zlavergne it will ultimately depend on how the MapRules are configured for any given project, meaning there is some flexibility with how the logic is applied (eg. Feaure MUST HAVE this tag or MAY HAVE this other tag). However, what's nice about the iD integration is that it will limit the presets that a user can see, so while they can still add tags manually when editing a feature, it will be more difficult to make accidental or random tags.

Warnings/suggestions are flagged when a user clicks save, but does not prevent uploading.

[abalosc1]

I'm also thinking we either add a new button like "Start Editor with Guidelines" or add an option it would default to like "iD editor with guidelines" So that if they're an advanced user who doesn't want the presets to be restricted in iD, they can still open iD like they regularly do