If I understand correctly the tasking-manager.env file is built into the container instead of mounting it as a volume. This requires rebuilding the container if the .env changes. Splitting the file into the following three groups would provide the opportunity to
include stable config needed during container build into the building procedure
define .env variable for postgres
mount config needed during container startup as volume to make it effective on container restart
Traefik
Treafik may be used by HOT on their server and is a good suggestion for everyone. As such it should be mentioned in the docker setup documentation. But it makes the Tasking Manager docker complex and error prone. I suggest to remove it and expose the relevant ports instead. Any server setup and routing can then be done by the respective user/admin to her preferences.
Remove docker-compose.override
The docker-compose.override file should either be removed (If we override things by default, then why not put them in the main docker-compose?) or it should feature all and only the config that requires adaption by the user.
Additional context
Related: #5087
Your project has taught me a lot and introduced me to traefik. Thanks for that!
//edit: Is the docker make script used? Otherwise it could be deleted to de-clutter the repository.
eternaltyro
commented
1 year ago
Config file
If I understand correctly the
tasking-manager.envfile is built into the container instead of mounting it as a volume. This requires rebuilding the container if the .env changes. Splitting the file into the following three groups would provide the opportunity toTraefik
Treafik may be used by HOT on their server and is a good suggestion for everyone. As such it should be mentioned in the docker setup documentation. But it makes the Tasking Manager docker complex and error prone. I suggest to remove it and expose the relevant ports instead. Any server setup and routing can then be done by the respective user/admin to her preferences.
Remove docker-compose.override
The
docker-compose.overridefile should either be removed (If we override things by default, then why not put them in the main docker-compose?) or it should feature all and only the config that requires adaption by the user.Additional context
Related: #5087
Your project has taught me a lot and introduced me to traefik. Thanks for that!
//edit: Is the docker make script used? Otherwise it could be deleted to de-clutter the repository.