search

hotosm / tasking-manager

Tasking Manager - The tool to team up for mapping in OpenStreetMap
https://wiki.openstreetmap.org/wiki/Tasking_Manager
BSD 2-Clause "Simplified" License
505 stars 270 forks source link

Improve revert validated tasks feature #5951

Open ramyaragupathy opened 1 year ago

ramyaragupathy commented 1 year ago

Feature request from a slack conversation w/ @RAytoun

Is your feature request related to a problem? Please describe.

Under Edit project -> Actions section, there is an option for Project Managers to revert validated tasks for a select user. This feature is used by Managers when the tasks marked for successful validation by a contributor still has data quality issues.

image

This action reverts the task status to Mapped status. If we have decided that that person has missed things, then the task should have been set at more mapping needed instead of mapped. If they are set at mapped, then another validator will need to check each one and revert it. So straight to invalidated would be the most useful.

Describe the solution you'd like

On revert, task status should be set to More mapping needed instead of Mapped

Additional context This feature was requested because the tasks checked have shown that that validator has been missing a lot of errors. Rather than laboriously checking each one, we assume that the validator has been careless with all of them. This may not be the case, but it is a far better use of time to let other mappers try to fix them before we have to check and validate again.

Aadesh-Baral commented 1 year ago

I believe it would be inconsistent with our current terminology to change the status of validated tasks to invalidated. Instead, I suggest we use the term "revert" to reflect the action accurately. To implement this change, we should modify how we present this feature in the front end, specifically by using the phrase "revert validated tasks."

Furthermore, it would be beneficial to create a separate endpoint specifically for this purpose. If we use the currently used endpoint for this change, we will be using the same endpoint to handle both reverting bad imagery tasks and changing the status of validated tasks to invalidated. However, since these actions serves different purposes, it would be more appropriate to have distinct endpoints. This way, we can avoid any confusion or potential conflicts arising from a single endpoint performing two different sets of actions.

cc @ramyaragupathy