hotosm / tasking-manager

Tasking Manager - The tool to team up for mapping in OpenStreetMap
https://wiki.openstreetmap.org/wiki/Tasking_Manager
BSD 2-Clause "Simplified" License
504 stars 270 forks source link

Fix ssm permissions to pull the AMI #6514

Closed dakotabenjamin closed 2 months ago

dakotabenjamin commented 2 months ago

What type of PR is this? (check all applicable)

Related Issue

Example: Fixes #6512 regression

Describe this PR

I had tested the PR using a role with admin level permissions, so I didn't catch the lack of permissions needed to GetParameters:

19:41:35Z *********: UPDATE_FAILED TaskingManagerLaunchTemplate: Resource handler returned message: "User: arn:aws:sts::************:assumed-role/*********************/backend-deploy is not authorized to perform: ssm:GetParameters on resource: arn:aws:ssm:*********:************:parameter/ami-01e5ff16fd6e8c542 because no identity-based policy allows the ssm:GetParameters action ...

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

dakotabenjamin commented 2 months ago

fyi @tsmock

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tsmock commented 2 months ago

That is funny; I didn't need it for my deployment. Although I was using the Terraform cloudformation_stack.