hotosm / tasking-manager

Tasking Manager - The tool to team up for mapping in OpenStreetMap
https://wiki.openstreetmap.org/wiki/Tasking_Manager
BSD 2-Clause "Simplified" License
509 stars 275 forks source link

Replace `craco` / `webpack` frontend module bundler with `vite` #6531

Open spwoodcock opened 2 months ago

spwoodcock commented 2 months ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Related to #5499

JoltCode commented 2 months ago

Another alternative for the list to consider is rspack - https://rspack.dev/ 😄

spwoodcock commented 2 months ago

Have you used rspack before?

From my understanding: webpack --> rspack rollup + esbuild --> rolldown (+vite) Both are rust libraries build to speed up bundling, doing the same thing.

It's hard to assess what the pros / cons of each might be though!

[!NOTE] Update - I really like the look of where rolldown and the oxc compiler are going. It seems like a solid foundation for the future of bundling, but I could be wrong!

JoltCode commented 2 months ago

Have you used rspack before?

From my understanding: webpack --> rspack rollup + esbuild --> rolldown (+vite) Both are rust libraries build to speed up bundling, doing the same thing.

It's hard to assess what the pros / cons of each might be though!

Note

Update - I really like the look of where rolldown and the oxc compiler are going. It seems like a solid foundation for the future of bundling, but I could be wrong!

Yeah exactly.

And I have used it - although only on a side project - in my opinion I think it's better for us to go with Vite, for the same reasons which you listed.

Let's just go for vite 😄

spwoodcock commented 2 months ago

[!NOTE] Based on discussions, this isn't such a simple task, as it involves renaming all .js files to have a .jsx extension if they are React components...