Upgrade/id - Githubissues

emi420 commented 2 months ago

What type of PR is this?

[x] ❓ Other (package upgrade)

Related Issue

Fixes #5780

Describe this PR

A new version (2.2.29) of the iD Editor was published as a NPM package on hotosm/id

This PR upgrades the package and also adds a configuration line for Webpack to ignore and not parse the iD.min.js file, as it was raising some warnings:

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 14:40-47
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 17:37-44
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 40022:67-76
Critical dependency: the request of a dependency is an expression

It should be ok as this is a packed and minified file.

Copy static files and imagery patch

I've also divided the commands in package.json for copying static files for both iD and Rapid and removed the patch for the iD imagery as isn't being used anymore.