scripts/docker/Dockerfile.backend deprecated?

hotosm / tasking-manager

Tasking Manager - The tool to team up for mapping in OpenStreetMap

https://wiki.openstreetmap.org/wiki/Tasking_Manager

BSD 2-Clause "Simplified" License

510 stars 275 forks source link

scripts/docker/Dockerfile.backend deprecated? #6552

Closed frafra closed 2 months ago

frafra commented 2 months ago

Shoud scripts/docker/Dockerfile.backend be deleted, since the compose file uses the Dockerfile in the root of the project?

ramyaragupathy commented 2 months ago

cc @mahesh-naxa @spwoodcock

spwoodcock commented 2 months ago

Thanks @frafra!

Related to https://github.com/hotosm/tasking-manager/pull/6436 which updated scripts/docker/Dockerfile.backend instead of Dockerfile.

I was under the impression that the deployments for TM in AWS are not using Docker anyway. The docker setup is only for local development currently. Is this right @dakotabenjamin?

If so, we can delete scripts/docker/Dockerfile.backend as mentioned, as it's a duplicate 👍

dakotabenjamin commented 2 months ago

@mahesh-naxa which dockerfiles will you be using for containerization?

frafra commented 2 months ago

I mean, scripts/docker/Dockerfile.backend is not even working with the current compose, because the healthcheck requires curl, and without curl the healthcheck fails and traefik does not forward the connection to an unhealthy container. This has been fixed on the main Dockerfile, but not on scripts/docker/Dockerfile.backend. The other option would be moving Dockerfile to scripts/docker/Dockerfile.backend and keep all dockerfiles there.