search

hotsapi / HotsStats

An app that shows player stats during loading screen in Heroes of the Storm
MIT License
145 stars 24 forks source link

Error Handling #18

Open andrei-ivanovici opened 8 years ago

andrei-ivanovici commented 8 years ago

We definitely need a better way to log our errors. My first recommendation would be to use a logging framework like Log4Net. I've used it successfully with other projects at work. If we come to an agreement, I can fully integrate it in less than a day

poma commented 8 years ago

Totally agree on that. However I prefer to use NLog. It does the same thing but is simpler and less verbose. Also according to some sources it is faster but it doesn't really matter for this project.

andrei-ivanovici commented 8 years ago

Great. I'll pick it up today when I get home. Might create another PR at the end of the day

poma commented 8 years ago

I already integrated it but before adding logging in lots of places I wanted to review your pull request to avoid lots of merge conflicts.

andrei-ivanovici commented 8 years ago

cool :+1: , I'll wait for your commits and pick it up afterwards. In the meantime, I'll continue with the MVVM stuff. I can merge any conflicting changes with the mvvm branch